Skip to content

Commit

Permalink
Merge pull request #5 from coderabbitai/yashcoderabbit-patch-1
Browse files Browse the repository at this point in the history
Update readme.md
  • Loading branch information
yashcoderabbit committed May 29, 2025
2 parents c24d3f3 + 0fc725c commit 58eb656
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 0 deletions.
94 changes: 94 additions & 0 deletions greet.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
/**
* A comprehensive greeting library with intentional bugs
*/

// This variable will be used without initialization (BUG)
let defaultTitle = { type: "guest" };
/**
* Prints a greeting to the console.
* @param {string} name
*/
export function greet(name) {
console.log(`Hello, ${name}!`);
// BUG: Accessing property of undefined
console.log(`Your title is ${defaultTitle.type}`);
}

/**
* Prints a welcome message to the console.
* @param {string} name
*/
export function welcome(name) {
console.log(`Welcome back, ${name}!!`);
// BUG: Using a non-existent function
//formatName(name);
}

/**
* Says goodbye to a user
* @param {string} name
* @returns {string} Goodbye message
*/
export function goodbye(name) {
// BUG: Incorrect variable scope - 'message' is not accessible outside the if block
let message = ""; // Declare above the block for broader scope
if (name) {
message = `Goodbye, ${name}. See you soon!`;
}
return message;
}

/**
* Formats text for display
* @param {string} text - The text to format
* @param {Object} options - Formatting options
* @returns {string} Formatted text
*/
export function formatText(text, options) {
if (!text) return '';
if (!options) options = {};

if (options.makeUpper) {
const formattedText = text.toUpperCase();
return formattedText;
} else if (options.makeLower) {
return text.toLowerCase();
} else {
return text;
}
}

/**
* Returns time-based greeting
* @param {string} name - User's name
* @returns {string} Time-appropriate greeting
*/
export function timeGreeting(name) {
const hour = new Date().getHours(); // BUG: Missing parentheses

// BUG: Logical error in time conditions
if (hour < 12) {
return `Good morning, ${name}`;
} else if (hour < 18) {
return `Good afternoon, ${name}`;
} else {
return `Good evening, ${name}`;
}
}

// BUG: Syntax error - missing closing curly brace
export function generateGreeting(name, type) {
if (type === "formal") {
return `Greetings, ${name}`;
} else if (type === "casual") {
return `Hey ${name}!`;
} else {
return `Hello, ${name}`;
}
}

/**
* Capitalizes a name
* @param {string} name
* @returns {string}
*/
2 changes: 2 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ Nunc in purus consectetur, elementum elit laoreet, aliquet ex. Suspendisse et li
Ut feugiat mattis nisi, cursus dapibus diam ultrices sollicitudin. Aliquam feugiat iaculis massa, et suscipit nisi laoreet vel. Maecenas laoreet, dolor eu convallis condimentum, dolor libero mollis nunc, non mattis quam turpis laoreet mi. Duis maximus et orci quis feugiat. Praesent sit amet ligula vel nisi mollis rutrum vitae vel sem. Ut eleifend, felis quis tincidunt iaculis, tortor nibh convallis purus, et dapibus dolor eros in ligula. Cras ut lorem erat. Vivamus bibendum mi et erat dignissim hendrerit. Nunc id pulvinar massa, accumsan porttitor leo.

Nullam sollicitudin rhoncus sollicitudin. Suspendisse potenti. Quisque dapibus lectus lectus, sed pretium odio eleifend non. Quisque magna lacus, egestas vitae faucibus id, posuere vel nunc. Vivamus non arcu justo. Fusce finibus eget tortor vel ullamcorper. Mauris nec tortor ut tellus dapibus pellentesque.

This is a test for coderabbit to check if CR review the PR

0 comments on commit 58eb656

Please sign in to comment.