-
Notifications
You must be signed in to change notification settings - Fork 0
Remove show_api from demo.launch #1
base: replay-353-base-6e501f6
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughGradio demo.launch call changed: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
@admin-coderabbit full review |
|
@coderabbit-eval full review |
|
@admin-coderabbit: I'll perform a full review of the PR changes. ✅ Actions performedFull review triggered. |
|
@admin-coderabbit, I'll perform a comprehensive review of all the changes in this PR. ✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/polite-buttons-sin.md (1)
5-5: Minor formatting issue and incomplete description.
- Missing space after the colon:
feat:Remove→feat: Remove- The description mentions removing
show_apibut doesn't note the addition offooter_links=["gradio", "settings"]- Since the PR objective is fixing a bug (HF Spaces compatibility), consider using
fix:prefix instead offeat:Suggested update
-feat:Remove show_api from demo.launch +fix: Remove show_api from demo.launchOr if the footer_links addition is intentional:
-feat:Remove show_api from demo.launch +fix: Remove show_api and add footer_links to demo.launch
📜 Review details
Configuration used: Environment YAML
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/polite-buttons-sin.mdtrackio/ui/main.py
🔇 Additional comments (1)
trackio/ui/main.py (1)
1449-1454: The fix correctly addresses Gradio 6.x compatibility.The removal of
show_api=Falseand replacement withfooter_links=["gradio", "settings"]is the proper migration for Gradio 6.x, wherefooter_linksis the standard parameter replacing the deprecatedshow_api. Both approaches functionally achieve the same result—hiding the API link in the footer while preserving other footer elements. The project's dependency ongradio[oauth]>=6.0.0,<7.0.0fully supports this parameter.
Short description
This PR removes
show_api=Falsefrom main.py as it's currently causing exceptions in new trackio projects automatically launched to HF Spaces. The gradio version included when launching a new trackio project in a HF Space doesn't contain that param, resulting on an exception that prevents the Space from starting.AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
Type of Change
Related Issues
If this PR closes an issue, please link it below:
Closes:
Testing and linting
Please run tests before submitting changes:
and format your code using Ruff:
ruff check --fix --select I && ruff formatSummary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.