Skip to content

Remove show_api from demo.launch #1

Open
wants to merge 4 commits into
base: replay-353-base-6e501f6
Choose a base branch
from

Conversation

admin-coderabbit
Copy link
Owner

@admin-coderabbit admin-coderabbit commented Jan 8, 2026

Short description

This PR removes show_api=False from main.py as it's currently causing exceptions in new trackio projects automatically launched to HF Spaces. The gradio version included when launching a new trackio project in a HF Space doesn't contain that param, resulting on an exception that prevents the Space from starting.

Screenshot 2025-12-08 at 16 28 02

AI Disclosure

We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.


  • I used AI to... [fill here]
  • I did not use AI

Type of Change

  • Bug fix
  • New feature (non-breaking)
  • New feature (breaking change)
  • Documentation update
  • Test improvements

Related Issues

If this PR closes an issue, please link it below:

Closes:

Testing and linting

Please run tests before submitting changes:

python -m pytest

and format your code using Ruff:

ruff check --fix --select I && ruff format

Summary by CodeRabbit

  • New Features

    • Footer now displays navigation links in the application interface.
  • Chores

    • Added a changeset entry and adjusted demo launch configuration to enable footer links and refine demo UI behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbit-eval
Copy link

coderabbit-eval bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

Gradio demo.launch call changed: show_api=False replaced with footer_links=["gradio", "settings"]. Added a new changeset file .changeset/polite-buttons-sin.md documenting a minor trackio change. No public API or signature changes.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/polite-buttons-sin.md
Adds a changeset file with front matter trackio: minor and note feat:Remove show_api from demo.launch; metadata-only.
Gradio Configuration
trackio/ui/main.py
Updates demo.launch() call: replaces show_api=False with footer_links=["gradio", "settings"], altering footer presentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through code with a cheerful grin,
Swapped a flag, let new footers begin,
A tiny changeset snug and neat,
Interface tweaks — a small, sweet feat! ✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the show_api parameter from demo.launch in main.py, which directly aligns with the changeset.
Description check ✅ Passed The PR description includes all required sections: short description explaining the bug fix with context, AI disclosure checkbox properly marked, type of change marked as bug fix, and testing/linting instructions provided.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbit eval help to get the list of available commands and usage tips.

@admin-coderabbit
Copy link
Owner Author

@admin-coderabbit full review

@admin-coderabbit
Copy link
Owner Author

@coderabbit-eval full review

Copy link

@admin-coderabbit: I'll perform a full review of the PR changes.

✅ Actions performed

Full review triggered.

@coderabbit-eval
Copy link

@admin-coderabbit, I'll perform a comprehensive review of all the changes in this PR.

✅ Actions performed

Full review triggered.

Copy link

@coderabbit-eval coderabbit-eval bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/polite-buttons-sin.md (1)

5-5: Minor formatting issue and incomplete description.

  1. Missing space after the colon: feat:Removefeat: Remove
  2. The description mentions removing show_api but doesn't note the addition of footer_links=["gradio", "settings"]
  3. Since the PR objective is fixing a bug (HF Spaces compatibility), consider using fix: prefix instead of feat:
Suggested update
-feat:Remove show_api from demo.launch
+fix: Remove show_api from demo.launch

Or if the footer_links addition is intentional:

-feat:Remove show_api from demo.launch
+fix: Remove show_api and add footer_links to demo.launch
📜 Review details

Configuration used: Environment YAML

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e501f6 and a1fe7ed.

📒 Files selected for processing (2)
  • .changeset/polite-buttons-sin.md
  • trackio/ui/main.py
🔇 Additional comments (1)
trackio/ui/main.py (1)

1449-1454: The fix correctly addresses Gradio 6.x compatibility.

The removal of show_api=False and replacement with footer_links=["gradio", "settings"] is the proper migration for Gradio 6.x, where footer_links is the standard parameter replacing the deprecated show_api. Both approaches functionally achieve the same result—hiding the API link in the footer while preserving other footer elements. The project's dependency on gradio[oauth]>=6.0.0,<7.0.0 fully supports this parameter.

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant