Merge pull request #1210 from elie222/fix/stripe-webhook-error-response

admin-coderabbit · Jan 5, 2026 · 952c0a2 · 952c0a2
2 parents b23d2e3 + 65e9815
commit 952c0a2
Showing 1 changed file with 12 additions and 17 deletions.
diff --git a/apps/web/app/api/stripe/webhook/route.ts b/apps/web/app/api/stripe/webhook/route.ts
@@ -17,27 +17,22 @@ export const POST = withError("stripe/webhook", async (request) => {
 
   if (!signature) return NextResponse.json({}, { status: 400 });
 
-  async function doEventProcessing() {
-    if (typeof signature !== "string") throw new Error("Header isn't a string");
-
-    if (!env.STRIPE_WEBHOOK_SECRET)
-      throw new Error("STRIPE_WEBHOOK_SECRET is not set");
-
-    const event = getStripe().webhooks.constructEvent(
-      body,
-      signature,
-      env.STRIPE_WEBHOOK_SECRET,
-    );
-
-    after(() => processEvent(event, logger));
+  if (typeof signature !== "string") {
+    throw new Error("Header isn't a string");
   }
 
-  try {
-    await doEventProcessing();
-  } catch (error) {
-    logger.error("Error processing event", { error });
+  if (!env.STRIPE_WEBHOOK_SECRET) {
+    throw new Error("STRIPE_WEBHOOK_SECRET is not set");
   }
 
+  const event = getStripe().webhooks.constructEvent(
+    body,
+    signature,
+    env.STRIPE_WEBHOOK_SECRET,
+  );
+
+  after(() => processEvent(event, logger));
+
   return NextResponse.json({ received: true });
 });