-
Notifications
You must be signed in to change notification settings - Fork 0
Automated Test: advanced-sql-analytics #339
Closed
+47
−34
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package sql | ||
|
|
||
| import ( | ||
| "errors" | ||
|
|
||
| "github.com/grafana/grafana-plugin-sdk-go/data" | ||
| ) | ||
|
|
||
| type DB struct { | ||
| } | ||
|
|
||
| func (db *DB) TablesList(rawSQL string) ([]string, error) { | ||
| return nil, errors.New("not implemented") | ||
| } | ||
|
|
||
| func (db *DB) RunCommands(commands []string) (string, error) { | ||
| return "", errors.New("not implemented") | ||
| } | ||
|
|
||
| func (db *DB) QueryFramesInto(name string, query string, frames []*data.Frame, f *data.Frame) error { | ||
| return errors.New("not implemented") | ||
| } | ||
|
|
||
| func NewInMemoryDB() *DB { | ||
| return &DB{} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableSqlExpressionsalways returnsfalse— logic is misleading and likely buggy.This function unconditionally returns
falseregardless of the feature flag state:enabled := !h.features.IsEnabledGlobally(...)— the negation inverts the meaning, soenabledistruewhen the flag is off.if enabledbranch and the fallthrough returnfalse.If the intent is to permanently block SQL expressions for now, simplify to
return falseto make the intent clear. If the intent is to eventually gate on the feature flag, the correct implementation would be:The current code is a maintenance hazard — a future developer removing one of the
return falsestatements would still face the inverted boolean, resulting in the feature being enabled when the flag is off and disabled when it's on.Proposed fix (if intent is to always block)
func enableSqlExpressions(h *ExpressionQueryReader) bool { - enabled := !h.features.IsEnabledGlobally(featuremgmt.FlagSqlExpressions) - if enabled { - return false - } return false }Proposed fix (if intent is to respect the feature flag)
func enableSqlExpressions(h *ExpressionQueryReader) bool { - enabled := !h.features.IsEnabledGlobally(featuremgmt.FlagSqlExpressions) - if enabled { - return false - } - return false + return h.features.IsEnabledGlobally(featuremgmt.FlagSqlExpressions) }🤖 Prompt for AI Agents